On Fri, Oct 1, 2010 at 11:10 AM, Guido Trotter <[email protected]> wrote: >> diff --git a/lib/constants.py b/lib/constants.py >> index 114cf91..8169646 100644 >> --- a/lib/constants.py >> +++ b/lib/constants.py >> @@ -566,6 +566,7 @@ HV_KVM_FLAG = "kvm_flag" >> HV_VHOST_NET = "vhost_net" >> HV_KVM_USE_CHROOT = "use_chroot" >> HV_CPU_MASK = "cpu_mask" >> +HV_HUGEPAGES_PATH = "hugepages_path" >> > > Should this be hugepages_path or mem_path? >
Well, command line madness. When mapping Ganeti configuration parameters to the name of the real command line parameters, maybe naming them as closest as possible might be a good idea. I have no strong feelings about it. >> HV_KVM_USE_CHROOT: False, >> + HV_HUGEPAGES_PATH: '', > > Will change this to "" for the styleguide. > Oops, my bad. Do want me do resend it? By the way, I've already signed the developer agreement. Regards, Miguel
