Retrieving tags can be done while the lock is shared. Only writing needs to be exclusive.
Also add a FIXME for cluster tags, where the code currently doesn't use any locks except the config lock. Signed-off-by: Michael Hanselmann <[email protected]> --- lib/cmdlib.py | 9 +++++++++ 1 files changed, 9 insertions(+), 0 deletions(-) diff --git a/lib/cmdlib.py b/lib/cmdlib.py index 740e3ab..3f0abb4 100644 --- a/lib/cmdlib.py +++ b/lib/cmdlib.py @@ -9787,6 +9787,9 @@ class TagsLU(NoHooksLU): # pylint: disable-msg=W0223 self.op.name = _ExpandInstanceName(self.cfg, self.op.name) self.needed_locks[locking.LEVEL_INSTANCE] = self.op.name + # FIXME: Acquire BGL for cluster tag operations (as of this writing it's + # not possible to acquire the BGL based on opcode parameters) + def CheckPrereq(self): """Check prerequisites. @@ -9813,6 +9816,12 @@ class LUGetTags(TagsLU): ] REQ_BGL = False + def ExpandNames(self): + TagsLU.ExpandNames(self) + + # Share locks as this is only a read operation + self.share_locks = dict.fromkeys(locking.LEVELS, 1) + def Exec(self, feedback_fn): """Returns the tag list. -- 1.7.0.4
