On Mon, Oct 4, 2010 at 3:19 PM, Miguel Di Ciurcio Filho <[email protected]> wrote: > On Mon, Oct 4, 2010 at 10:26 AM, Michael Hanselmann <[email protected]> wrote: >> >> Defaults shouldn't change unless there a really good reason for it. >> Can't you do this depending on the KVM version in use instead of >> requiring the user to change a setting? >> >> hv_kvm: >> … >> if kvm_version > 0x…: >> args.append("new networking") >> else: >> args.append("old stuff goes here") >> > > That is the best solution, indeed. Although, I couldn't find out how > to get the kvm version. I need some guidance to write a new patch. >
Eh, interesting questions indeed. Newer kvm versions give it with kvm --version Older ones, of course, don't! :/ I guess we check the version and if none is returned assume it's "ancient" and otherwise if it's >= 0.12 go with the new model. What do you think? Thanks, Guido
