On Sat, Nov 27, 2010 at 03:05:13PM -0200, Michael Hanselmann wrote: > Am 27. November 2010 14:23 schrieb Iustin Pop <[email protected]>: > > diff --git a/test/ganeti.hypervisor.unittest.py > > b/test/ganeti.hypervisor.unittest.py > > new file mode 100644 > > index 0000000..d42bc9f > > --- /dev/null > > +++ b/test/ganeti.hypervisor.unittest.py > > This file needs to be added to Makefile.am. > > > […] > > +import testutils > > + > > +class TestParameters(unittest.TestCase): > > Two empty lines at module level. > > > + def test(self): > > + for hv, const_params in constants.HVC_DEFAULTS.items(): > > Rest LGTM.
Grr, committed wrong patch. That async unittest breakage is really annoying, as I cannot run anymore make check. Patch fixing the Makefile.am stuff coming. sorry! iustin
