On Sun, Nov 28, 2010 at 13:57, Iustin Pop <[email protected]> wrote: > On Sat, Nov 27, 2010 at 06:16:40PM -0200, Michael Hanselmann wrote: > > Am 27. November 2010 17:52 schrieb Iustin Pop <[email protected]>: > > > --- a/lib/cmdlib.py > > > +++ b/lib/cmdlib.py > > > @@ -1233,6 +1233,8 @@ class LUVerifyCluster(LogicalUnit): > > > ETYPE_ERROR = "ERROR" > > > ETYPE_WARNING = "WARNING" > > > > > > + _HOOKS_INDENT_RE = re.compile('^', re.M) > > > + > > > class NodeImage(object): > > > > Two empty lines at module level (and you could replace '' with "" here). > > This is not module level, this is (as the diff shows) in LUVerifyCluster > :) > > ' replaced with ". > > > > """A class representing the logical and physical status of a node. > > > […] > > > --- a/lib/rapi/connector.py > > > +++ b/lib/rapi/connector.py > > > @@ -92,18 +92,17 @@ class R_root(baserlib.R_Generic): > > > """/ resource. > > > > > > """ > > > - @staticmethod > > > - def GET(): > > > + _ROOT_PATTERN = re.compile("^R_([a-zA-Z0-9]+)$") > > > + @classmethod > > > > One empty line at class level. > > Done. > > > > + def GET(cls): > > > […] > > > --- a/lib/utils.py > > > +++ b/lib/utils.py > > > @@ -100,6 +100,14 @@ _MAC_CHECK = > re.compile("^([0-9a-f]{2}:){5}[0-9a-f]{2}$", re.I) > > > _TIMEOUT_TERM, > > > _TIMEOUT_KILL) = range(3) > > > > > > +#: Shell param checker regexp > > > +_SHELLPARAM_REGEX = re.compile(r"^[-a-zA-Z0-9._+/:%...@]+$") > > > + > > > +#: Unit checker regexp > > > +_PARSEUNIT_REGEX = re.compile(r"^([.\d]+)\s*([a-zA-Z]+)?$") > > > + > > > +#: ASN1 time regexp > > > +_ANS1_TIME_REGEX = re.compile(r"^(\d+)([-+]\d\d)(\d\d)$") >
s/ANS/ASN/ ? > > > > > > class RunResult(object): > > > > See above. :-) > > Done. > > thanks! > > iustin >
