Am 2. Dezember 2010 12:47 schrieb Miguel Di Ciurcio Filho <[email protected]>: > On Thu, Dec 2, 2010 at 12:41 PM, Michael Hanselmann <[email protected]> wrote: >>> + >>> + try: >>> + return (match.group(0), int(match.group(1)), int(match.group(2)), >>> + int(match.group(3))) >>> + except ValueError: >>> + return None >> >> Ganeti uses two spaces for indentation. Just use plain int() and let >> the exception propagate. If the version ever becomes non-numeric, >> changes are needed anyway. And you would silently swallow the error, >> which is not good (see logging.exception). > > Argh, sorry for the indentation. Resend?
Yes, please with addressing my other comments. Michael
