Re: [PATCH master 1/3] objects: Add definitions for query requests and responses

[Rene Nussbaumer]

On Fri, Dec 10, 2010 at 5:34 PM, Michael Hanselmann <han...@google.com> wrote:
> Also update description of QueryFieldDefinition.name.
> ---
>  lib/objects.py |   47 ++++++++++++++++++++++++++++++++++++++++++++++-
>  1 files changed, 46 insertions(+), 1 deletions(-)
>
> diff --git a/lib/objects.py b/lib/objects.py
> index 343c218..06a8dc2 100644
> --- a/lib/objects.py
> +++ b/lib/objects.py
> @@ -1380,7 +1380,7 @@ class ConfdReply(ConfigObject):
>  class QueryFieldDefinition(ConfigObject):
>   """Object holding a query field definition.
>
> - �...@ivar name: Field name as a regular expression
> + �...@ivar name: Field name
>   @ivar title: Human-readable title
>   @ivar kind: Field type
>
> @@ -1392,6 +1392,51 @@ class QueryFieldDefinition(ConfigObject):
>     ]
>
>
> +class QueryRequest(ConfigObject):
> +  """Object holding a query request.
> +
> +  """
> +  __slots__ = [
> +    "what",
> +    "fields",
> +    "filter",
> +    ]
> +
> +
> +class QueryResponse(ConfigObject):
> +  """Object holding the response to a query.
> +
> + �...@ivar fields: List of L{QueryFieldDefinition} objects
> + �...@ivar data: Requested data
> +
> +  """
> +  __slots__ = [
> +    "fields",
> +    "data",
> +    ]
> +
> +
> +class QueryFieldsRequest(ConfigObject):
> +  """Object holding a request for querying available fields.
> +
> +  """
> +  __slots__ = [
> +    "what",
> +    "fields",
> +    ]
> +
> +
> +class QueryFieldsResponse(ConfigObject):
> +  """Object holding the response to a query for fields.
> +
> + �...@ivar fields: List of L{QueryFieldDefinition} objects
> +
> +  """
> +  __slots__ = [
> +    "fields",
> +    ]
> +
> +
>  class SerializableConfigParser(ConfigParser.SafeConfigParser):
>   """Simple wrapper over ConfigParse that allows serialization.
>
> --
> 1.7.3.1

LGTM

>
>