On Mon, Jan 10, 2011 at 15:23 +0000, Michael Hanselmann <[email protected]> 
wrote:
> Am 10. Januar 2011 15:00 schrieb Adeodato Simo <[email protected]>:
> > +  Expects node1 and node2 to be primary and secondary for a common 
> > instance.

> Please put this into an assertion.
> assert node1 != node2

Done.

--- qa/qa_group.py
+++ qa/qa_group.py
@@ -103,6 +103,7 @@ def TestAssignNodesIncludingSplit(orig_group, node1, node2):
   Expects node1 and node2 to be primary and secondary for a common instance.
 
   """
+  assert node1 != node2
   groups = qa_config.get("groups", {})
   other_group = groups.get("inexistent-groups", ["group1"])[0]
 
> Rest LGTM.

Thanks, will submit.

-- 
Adeodato Simo | [email protected]
Corp Computing Services SRE (Dublin)

Reply via email to