On Tue, Jan 11, 2011 at 11:41 AM, Michael Hanselmann <[email protected]> wrote:
> Am 11. Januar 2011 10:21 schrieb René Nussbaumer <[email protected]>:
>> +def BlockdevPauseResumeSync(disks, pause):
>> + success = []
>> + for disk in disks:
>> + try:
>> + rdev = _RecursiveFindBD(disk)
>> + except errors.BlockDeviceError:
>> + rdev = None
>
> Let's assume rdev is None.
>
>> + if not rdev:
>> + success.append((False, "Cannot change sync for device %s: device not
>> found" % disk.iv_name))
>
> You add the message here.
>
>> + result = rdev.PauseResumeSync(pause)
>
> Oups, boom!
>
>> + if result:
>> + success.append((result, None))
>> […]
Nice catch. Interdiff:
diff --git a/lib/backend.py b/lib/backend.py
index 3347829..ced614d 100644
--- a/lib/backend.py
+++ b/lib/backend.py
@@ -1371,6 +1371,7 @@ def BlockdevPauseResumeSync(disks, pause):
if not rdev:
success.append((False, "Cannot change sync for device %s:
device not found" % disk.iv_name))
+ continue
result = rdev.PauseResumeSync(pause)
René
