On Tue, Jan 18, 2011 at 12:04 PM, Apollon Oikonomopoulos <[email protected]> wrote: > On 11:57 Tue 18 Jan , Guido Trotter wrote: >> LGTM with: >> >> diff --git a/lib/hypervisor/hv_kvm.py b/lib/hypervisor/hv_kvm.py >> index 5684a87..3e9e025 100644 >> --- a/lib/hypervisor/hv_kvm.py >> +++ b/lib/hypervisor/hv_kvm.py >> @@ -34,7 +34,6 @@ import pwd >> import struct >> import fcntl >> import shutil >> -from cStringIO import StringIO >> >> from ganeti import utils >> from ganeti import constants >> @@ -994,8 +993,8 @@ class KVMHypervisor(hv_base.BaseHypervisor): >> try: >> tap = utils.ReadFile(self._InstanceNICFile(instance.name, >> nic_seq)) >> except EnvironmentError, err: >> - logging.warning("Failed to find host interface for %s NIC #%d: >> %s" % >> - (instance.name, nic_seq, str(err))) >> + logging.warning("Failed to find host interface for %s NIC #%d: >> %s", >> + instance.name, nic_seq, str(err)) >> continue >> try: >> self._ConfigureNIC(instance, nic_seq, nic, tap) >> >> Thanks, >> >> Guido > > Should I make the changes or will you make them while pushing? >
Doing them while pushing, wanted to just note them on the thread Thanks, Guido
