On Wed, Feb 9, 2011 at 14:47 +0100, Iustin Pop <ius...@google.com> wrote: > > I'd say order-only prerequisites are a rather rare make feature (at > > least, I had never come accross them myself). Perhaps it'd be good to > > add a comment before the rule, briefly explaining what is being done? > > (Saving a trip to git-blame.)
> Note that we already use them in a few places in the Makefile. Oh, I see: my bad. :-) > > A brief summay of the commit message should do the trick. > How does this look? > diff --git a/Makefile.am b/Makefile.am > index 507bbf4..099d5d8 100644 > --- a/Makefile.am > +++ b/Makefile.am > @@ -261,6 +261,11 @@ docrst = \ > $(RUN_IN_TEMPDIR): | $(all_dirfiles) > +# Note: we use here an order-only prerequisite, as the contents of > +# _autoconf.py are not actually influencing the html build output: it > +# has to exist in order for the sphinx module to be loaded > +# successfully, but we certainly don't want the docs to be rebuilt if > +# it changes > doc/html/index.html: $(docrst) $(docpng) doc/conf.py configure.ac \ > $(RUN_IN_TEMPDIR) lib/build/sphinx_ext.py lib/opcodes.py lib/ht.py \ > | lib/_autoconf.py LGTM, thanks! -- Adeodato Simo | d...@google.com Corp Computing Services SRE (Dublin)
