On Tue, Feb 15, 2011 at 01:46:06PM +0100, Michael Hanselmann wrote: > There are quite many hardcoded constants (e.g. “[…] one of ``file``, > ``lvm-pv`` or ``lvm-vg`` […]). By using constants it'll be easier to > identify these. > > With such lists of values it's also easy to miss some when > extending/changing something. By adding assertions inlined with reST, > these can also be detected.
LGTM.
