Re: [PATCH master] ht: Add strict ceck for dictionaries

[Michael Hanselmann]

Am 17. Mai 2011 16:01 schrieb Iustin Pop <ius...@google.com>:
> On Tue, May 17, 2011 at 04:24:33PM +0200, Michael Hanselmann wrote:
>> +  def testStrictDict(self):
>> +    fn = ht.TStrictDict(False, False, { "a": ht.TInt, })
>> +    print fn
> […]
>
> Err, wanted to ask: what's with this "print fn" in the tests?

Missed them as leftovers from testing. Will push with the following interdiff:

--- a/test/ganeti.ht_unittest.py
+++ b/test/ganeti.ht_unittest.py
@@ -189,7 +189,6 @@ class TestTypeChecks(unittest.TestCase):

   def testStrictDictRequireAllExclusive(self):
     fn = ht.TStrictDict(True, True, { "a": ht.TInt, })
-    print fn
     self.assertFalse(fn(1))
     self.assertFalse(fn(None))
     self.assertFalse(fn({}))
@@ -201,7 +200,6 @@ class TestTypeChecks(unittest.TestCase):
     self.assertTrue(fn({"a": -5, }))

     fn = ht.TStrictDict(True, True, { "a": ht.TInt, "x": ht.TString, })
-    print fn
     self.assertFalse(fn({}))
     self.assertFalse(fn({"a": -5, }))
     self.assertTrue(fn({"a": 123, "x": "", }))
@@ -209,7 +207,6 @@ class TestTypeChecks(unittest.TestCase):

   def testStrictDictExclusive(self):
     fn = ht.TStrictDict(False, True, { "a": ht.TInt, "b": ht.TList, })
-    print fn
     self.assertTrue(fn({}))
     self.assertTrue(fn({"a": 123, }))
     self.assertTrue(fn({"b": range(4), }))
@@ -220,7 +217,6 @@ class TestTypeChecks(unittest.TestCase):

   def testStrictDictRequireAll(self):
     fn = ht.TStrictDict(True, False, { "a": ht.TInt, "m": ht.TInt, })
-    print fn
     self.assertTrue(fn({"a": 1, "m": 2, "bar": object(), }))
     self.assertFalse(fn({}))
     self.assertFalse(fn({"a": 1, "bar": object(), }))
@@ -228,7 +224,6 @@ class TestTypeChecks(unittest.TestCase):

   def testStrictDict(self):
     fn = ht.TStrictDict(False, False, { "a": ht.TInt, })
-    print fn
     self.assertTrue(fn({}))
     self.assertFalse(fn({"a": ""}))
     self.assertTrue(fn({"a": 11}))

Michael