On Wed, May 25, 2011 at 05:45:13PM +0200, Michael Hanselmann wrote: > Am 25. Mai 2011 13:34 schrieb Iustin Pop <[email protected]>: > > On Wed, May 25, 2011 at 12:07:24PM +0200, Michael Hanselmann wrote: > >> The only place where they're used is for sorting the results. If > >> “SubmitPending” and “QueueJob” were to be called multiple times, there > >> can also be duplicate indices (the former uses enumerate() on the > >> internal queue). Should I change JobExecutor, maybe in a separate > >> patch, to use a counter for all job additions? > > > > That sounds good, thanks! > > See the other patch and this interdiff: > > - self.jobs.append((0, status, job_id, name)) > + self.jobs.append((self._counter.next(), status, job_id, name))
LGTM.
