On Thu, May 26, 2011 at 02:37:25PM +0200, Michael Hanselmann wrote: > Commit 1bee66f3 added assertions for ensuring only the necessary locks > are kept while replacing disks. One of them makes sure locks have been > released during the operation. Unfortunately the commit added the check > as part of a “finally” branch, which is also run when an exception is > thrown (in which case the locks may not have been released yet). Errors > could be masked by the assertion error. Moving the check out of the > “finally” branch fixes the issue.
LGTM. Note typo in subject. (And I'm glad for the patch, as I dislike try: return foo finally/except:.. :) iustin
