On Tue, May 31, 2011 at 05:00:57PM +0200, Guido Trotter wrote: > Note that --no-disk-moves and --no-instance-moves are not incompatible, > but if both are used no solution can possibly exist. > > Signed-off-by: Guido Trotter <[email protected]> > --- > htools/Ganeti/HTools/Cluster.hs | 28 +++++++++++++++++++--------- > htools/Ganeti/HTools/QC.hs | 8 ++++---- > htools/hbal.hs | 4 ++-- > 3 files changed, 25 insertions(+), 15 deletions(-) > > diff --git a/htools/Ganeti/HTools/Cluster.hs b/htools/Ganeti/HTools/Cluster.hs > index 48e4b6a..fca08ad 100644 > --- a/htools/Ganeti/HTools/Cluster.hs > +++ b/htools/Ganeti/HTools/Cluster.hs > @@ -465,35 +465,42 @@ checkSingleStep ini_tbl target cur_tbl move = > -- the current candidate target node, generate the possible moves for > -- a instance. > possibleMoves :: Bool -- ^ Whether the secondary node is a valid new > node > + -> Bool -- ^ Whether the primary node is a valid new node
I believe this docstring is wrong. It should rather be "whether we're allowed to change the primary node". thanks, iustin
