On Fri, Jun 10, 2011 at 05:46:52PM +0200, Michael Hanselmann wrote:
> Am 10. Juni 2011 17:41 schrieb Iustin Pop <[email protected]>:
> > Basically I see these as very different operations, hence I like the
> > clear separation. In an emergency, I would suspect that Ganeti does two
> > steps: first in-group evacuation for what instances are possible to move
> > and then out-of group evacuation for the rest. But these as separate
> > logical steps.
> 
> Interdiff:
> 
> @@ -54,10 +54,8 @@ Node evacuation
>  Evacuates instances off their primary nodes. The evacuation mode
>  can be given as ``primary-only``, ``secondary-only`` or
>  ``all``. The call is given a list of instances whose primary nodes need
> -to be in the same node group.
> -
> -The iallocator can decide whether it wants to keep instances in the same
> -node group or move them to another group.
> +to be in the same node group. The returned nodes need to be in the same
> +group as the original primary node.

LGTM (but was curious what you think, rather than just interdiff).

thanks,
iustin

Reply via email to