On Mon, Oct 24, 2011 at 06:46:37PM +0200, Michael Hanselmann wrote: > Before this patch it would take a variable number of arguments, which > isn't very good for a definition-based approach. > --- > lib/rpc.py | 2 +- > lib/server/noded.py | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/lib/rpc.py b/lib/rpc.py > index 61dbe88..5599311 100644 > --- a/lib/rpc.py > +++ b/lib/rpc.py > @@ -1010,7 +1010,7 @@ class RpcRunner(object): > > """ > return self._SingleNodeCall(node, "blockdev_rename", > - [(d.ToDict(), uid) for d, uid in devlist]) > + [[(d.ToDict(), uid) for d, uid in devlist]]) > > @_RpcTimeout(_TMO_NORMAL) > def call_blockdev_pause_resume_sync(self, node, disks, pause): > diff --git a/lib/server/noded.py b/lib/server/noded.py > index c67da12..2bb8161 100644 > --- a/lib/server/noded.py > +++ b/lib/server/noded.py > @@ -216,7 +216,7 @@ class NodeHttpServer(http.server.HttpServer): > """Remove a block device. > > """ > - devlist = [(objects.Disk.FromDict(ds), uid) for ds, uid in params] > + devlist = [(objects.Disk.FromDict(ds), uid) for ds, uid in (params, )]
Sorry, I can't read this properly, could you explain more? thanks, iustin
