On Mon, Oct 24, 2011 at 06:46:38PM +0200, Michael Hanselmann wrote:
> A new script, “autotools/build-rpc”, will be used to generate code for
> RPC client wrappers. This is done because “lib/rpc.py” contains lots and
> lots of boilerplate code. Forthcoming patches will start converting
> RPC wrappers.
> ---

> +def _WritePreamble(sw):
> +  """Writes a preamble for the RPC wrapper output.
> +
> +  """
> +  sw.Write("# This code is automatically generated at build time.")
> +  sw.Write("# Do not modify manually.")
> +  sw.Write("")
> +  sw.Write("\"\"\"Automatically generated RPC client wrappers.")
> +  sw.Write("")
> +  sw.Write("\"\"\"")
> +  sw.Write("")

Don't we have this somewhere else too (Makefile.am:PYTHON_BOOTSTRAP)? It
would be goo to have the same headers/style everywhere.

Rest LGTM, thanks.

iustin

Reply via email to