On Wed, Oct 26, 2011 at 01:26:14PM +0200, Michael Hanselmann wrote: > Am 26. Oktober 2011 12:56 schrieb Iustin Pop <[email protected]>: > > On Wed, Oct 26, 2011 at 12:46:48PM +0200, Michael Hanselmann wrote: > >> -# Timeout table that will be built later by decorators > >> -# Guidelines for choosing timeouts: > >> -# - call used during watcher: timeout -> 1min, _TMO_URGENT > >> -# - trivial (but be sure it is trivial) (e.g. reading a file): 5min, > >> _TMO_FAST > >> -# - other calls: 15 min, _TMO_NORMAL > >> -# - special calls (instance add, etc.): either _TMO_SLOW (1h) or huge > >> timeouts > > > > I can't find these comments somewhere else, so I think they should be > > moved near the rpc defs themselves. > > Oups, indeed. Interdiff: > > --- a/lib/build/rpc_definitions.py > +++ b/lib/build/rpc_definitions.py > @@ -37,7 +37,11 @@ RPC definition fields: > """ > > > -# Various time constants for the timeout table > +# Guidelines for choosing timeouts: > +# - call used during watcher: timeout of 1min, _TMO_URGENT > +# - trivial (but be sure it is trivial) (e.g. reading a file): 5min, > _TMO_FAST > +# - other calls: 15 min, _TMO_NORMAL > +# - special calls (instance add, etc.): either _TMO_SLOW (1h) or huge > timeouts > TMO_URGENT = 60 # one minute > TMO_FAST = 5 * 60 # five minutes > TMO_NORMAL = 15 * 60 # 15 minutes
LGTM, thanks! iustin
