On Thu, Dec 08, 2011 at 12:08:31PM +0100, Agata Murawska wrote: > On Thu, Dec 8, 2011 at 9:20 AM, Iustin Pop <[email protected]> wrote: > > On Tue, Dec 06, 2011 at 06:52:13PM +0100, Agata Murawska wrote: > >> gnt-cluster modify can now change instance policy specs. Again, sanity > >> checks are performed. > >> > >> Signed-off-by: Agata Murawska <[email protected]> > >> --- > >> lib/client/gnt_cluster.py | 17 ++++++++++++++++- > >> lib/cmdlib.py | 11 +++++++++++ > >> lib/opcodes.py | 1 + > >> 3 files changed, 28 insertions(+), 1 deletions(-) > >> > >> diff --git a/lib/client/gnt_cluster.py b/lib/client/gnt_cluster.py > >> index e3a8f8a..7c1cf0b 100644 > >> --- a/lib/client/gnt_cluster.py > >> +++ b/lib/client/gnt_cluster.py > >> @@ -919,7 +919,12 @@ def SetClusterParams(opts, args): > >> opts.master_netdev is not None or > >> opts.master_netmask is not None or > >> opts.use_external_mip_script is not None or > >> - opts.prealloc_wipe_disks is not None): > >> + opts.prealloc_wipe_disks is not None or > >> + opts.mem_count_ispecs is not None or > >> + opts.cpu_count_ispecs is not None or > >> + opts.disk_count_ispecs is not None or > >> + opts.disk_size_ispecs is not None or > >> + opts.nic_count_ispecs is not None): > > > > Right. Let me know when you submitted, this needs refactoring. > > > > LGTM, > > iustin > > Changes due to previous changes + styling issue Michael mentioned + > iteritems -> items in cmdlib:
LGTM.
