On Mon, Apr 23, 2012 at 10:33:46AM -0300, Michael Hanselmann wrote:
> Am 21. April 2012 06:58 schrieb Iustin Pop <[email protected]>:
> > The recent hooks additions are not style compliant (gasp!). Fix this.
> >
> > We might also want to fix missing copyright headers, but not sure
> > about that.
> 
> LGTM
> 
> > --- a/examples/hooks/defaultpasswords
> > +++ b/examples/hooks/defaultpasswords
> >  cat $(dirname $0)/confdata/defaultpasswords | chroot $TARGET chpasswd
> 
> Useless use of cat?

As opposed to chroot $TARGET chpasswd < … ? Possibly, but meh, it's not
broken.

thanks,
iustin

Reply via email to