Am 26. April 2012 05:03 schrieb Iustin Pop <[email protected]>:
> On Wed, Apr 25, 2012 at 09:58:29PM +0200, Michael Hanselmann wrote:
>> The “RunTestIf” uses an AND association between the passed test names,
>> so the instance would be be shut down if both rename and reinstall were
>> enabled. Since this is not necessarily the case, OR must be used.
>
> Good catch. However, this is fixing just this particular case (we might
> have more in the future); why not add a RunTestIfAny helper?
Unfortunately that won't work for some cases. Just yesterday I wrote
the following condition:
if (qa_config.TestEnabled(["instance-console", "rapi"]) or
qa_config.TestEnabled("instance-modify")):
I think I'll add a new class “Or”, so we can write the following:
RunTestIf(Or(["instance-console", "rapi"],
"instance-modify")), …)
This should be trivial to evaluate. Do you agree?
Michael
