On Fri, Sep 14, 2012 at 12:08 PM, Michael Hanselmann <han...@google.com> wrote: > 2012/9/14 Guido Trotter <ultrot...@google.com>: >> I believe we lock or don't lock depending on the RPC type, what it >> does, and how compatible it is with other RPCs, right? > > Recreating disks involves DRBD (or other block device types) and > unless other measures have been taken, locks must be used. You don't > want an instance creation to fail on a conflict on the DBRD minor > number.
Sure. The patch removes the lock for the _old_ primary, and only if disks are not created on it. As the comment implies, any node where disks are touched is locked. Bernardo