On Tue, Sep 18, 2012 at 3:31 PM, Michael Hanselmann <han...@google.com> wrote:
> First the numbers:
> $ stat --format '%s %n' doc/examples/bash_completion*
> 77847 doc/examples/bash_completion
> 86492 doc/examples/bash_completion-debug
>
> The non-debug version doesn't use indentation and does not have some
> (primitive) facilities for debugging. The savings are about 8.5 kB or
> 10 %. The “-debug” version is used by “devel/upload”.
> ---
> .gitignore | 1 +
> Makefile.am | 11 +++++-
> autotools/build-bash-completion | 75 +++++++++++++++++++++++---------------
> devel/upload.in | 4 +-
> 4 files changed, 57 insertions(+), 34 deletions(-)
Almost LGTM, except:
> def main():
> + parser = optparse.OptionParser(usage="%prog [--compact]")
> + parser.add_option("--compact", action="store_true",
> + help="Name of the instance")
"Name of the instance"? Moreover, I'm not sure that "compact" is a
good name, because you also disable debugging.
> # Burnin script
> burnin = build.LoadModule("tools/burnin")
> - WriteCompletion(sw, "%s/burnin" % constants.TOOLSDIR, "_ganeti_burnin",
> + WriteCompletion(sw, "%s/burnin" % constants.TOOLSDIR, "_ganeti_burnin",
> not options.compact,
Line too long, please break it.
Bernardo
