On Wed, Sep 26, 2012 at 05:38:20PM +0300, Constantinos Venetsanopoulos wrote: > The option is added to allow us the passing of arbitrary ext-params > during disk addition (gnt-instance modify --disk add: ...), same as > we do during instance add. > > The option is needed because during gnt-instance modify parameters' > validation, we do not know the type of the disk template > (whereas in gnt-instance add we find it from the -t option). > > The option is called 'arbit' and not 'ext' params because it may be > useful in other contexts too, in the future. > > The corresponding prereq checks for the existence of the 'provider' > parameter in case of an 'ext' template are also taken care off in > this commit. It serves as a general introduction of the 'ext' > template in gnt-instance modify. > > Signed-off-by: Constantinos Venetsanopoulos <[email protected]> > > Conflicts: > > lib/cmdlib.py
Conflicts? :) This is not a review of the patch, but just reading the commit message, I find "--allow-arbit-params" too hard to read. What about "--flexible-params"? thanks, iustin
