LGTM Thanks,
Guido On Mon, Oct 8, 2012 at 5:46 PM, Iustin Pop <[email protected]> wrote: > It seems a few of the error classes are no longer used: > > - LVMError, deprecated in 8c5533a5 > - ConfdRequestError, deprecated in b0dcdc10 > - SshKeyError, introduced in the initial open source commit but never used (⁈) > > Signed-off-by: Iustin Pop <[email protected]> > --- > There are some other errors used wrongly (for flow control in a single > function), I'll try to cleanup them later. > > lib/errors.py | 23 ----------------------- > 1 files changed, 0 insertions(+), 23 deletions(-) > > diff --git a/lib/errors.py b/lib/errors.py > index 062b658..ca3050f 100644 > --- a/lib/errors.py > +++ b/lib/errors.py > @@ -63,14 +63,6 @@ class GenericError(Exception): > """ > > > -class LVMError(GenericError): > - """LVM-related exception. > - > - This exception codifies problems with LVM setup. > - > - """ > - > - > class LockError(GenericError): > """Lock error exception. > > @@ -272,12 +264,6 @@ class TypeEnforcementError(GenericError): > """ > > > -class SshKeyError(GenericError): > - """Invalid SSH key. > - > - """ > - > - > class X509CertError(GenericError): > """Invalid X509 certificate. > > @@ -357,15 +343,6 @@ class JobQueueFull(JobQueueError): > """ > > > -class ConfdRequestError(GenericError): > - """A request error in Ganeti confd. > - > - Events that should make confd abort the current request and proceed serving > - different ones. > - > - """ > - > - > class ConfdMagicError(GenericError): > """A magic fourcc error in Ganeti confd. > > -- > 1.7.7.3 > -- Guido Trotter SRE - Corp Computing Services (aka Horsepower) Google Ireland
