On Tue, Oct 16, 2012 at 04:53:03PM +0300, Constantinos Venetsanopoulos wrote: > On 10/16/2012 03:45 PM, Iustin Pop wrote: > >On Mon, Oct 15, 2012 at 08:18:33PM +0300, Constantinos Venetsanopoulos wrote: > >>On 10/15/2012 6:58 PM, Constantinos Venetsanopoulos wrote: > >>>Hi iustin, > >>> > >>>I just sent you the interdiff. After rebasing, there is a trivial > >>>conflict > >>>when applying the next commit (2/7). I can resend it too, if you want. > >>I meant '3/7' here: Multiple ExtStorage providers > >The interdiff looks good. I'd appreciate if you either resend both 2/7 > >and 3/7, or point me to a git tree where I can pull them from. > > You can pull from: > > https://code.grnet.gr/git/ganeti-local > > branch 'master-extstorage-upstream2' > > You can squash commits 0f247c10 and 8237d5eb with 2/7, > when merging. I kept them separate to easy the review.
Thanks, sounds good. > >Also, should the design doc, i.e. 1/7, need to be slightly updated with > >the setinfo script? > > Of course. As I already said in the previous mail (2012/10/10) I will > be sending a separate patch after everything gets merged, that will > update the design doc and corresponding man pages to include the > setinfo functionality. Ah, missed that, sorry. Sounds good. iustin
