2012/11/12 Bernardo Dal Seno <bdals...@google.com>:
> On Fri, Nov 2, 2012 at 9:44 PM, Michael Hanselmann <han...@google.com> wrote:
>> --- a/lib/client/gnt_job.py
>> +++ b/lib/client/gnt_job.py
>> +  "change-priority": (
>> +    ChangePriority, [ArgJobId()],
>> +    [PRIORITY_OPT, FORCE_OPT, _PENDING_OPT, _QUEUED_OPT, _WAITING_OPT],
>> +    "--priority <priority> <job-id> [<job-id> ...]",
>
> Please add also the other options (like in cancel).
>
>> +    "Change the priority of a job"),
>
> s/a job/jobs/

-    "--priority <priority> <job-id> [<job-id> ...]",
-    "Change the priority of a job"),
+    "--priority <priority> {[--force] {--pending | --queued | --waiting} |"
+    " <job-id> [<job-id> ...]}",
+    "Change the priority of jobs"),

>> +Changes the priority of one or multiple pending jobs. Jobs currently
>> +currenting have the priority for any remaining opcode changed.
>
> s/currenting/running/; bonus points for s/currenting have the priority
> for any remaining opcode/running have only the priority of remaining
> opcodes/.
>
>> +``--priority`` must be specified. ``--queued`` and ``waiting`` can be
>> +used to cancel all jobs in the respective state, ``--pending`` includes
>
> s/cancel/operate on/ (or whatever else you like).

 Changes the priority of one or multiple pending jobs. Jobs currently
-currenting have the priority for any remaining opcode changed.
+running have only the priority of remaining opcodes changed.
 ``--priority`` must be specified. ``--queued`` and ``waiting`` can be
-used to cancel all jobs in the respective state, ``--pending`` includes
-both. To skip a confirmation, pass ``--force``.
+used to re-prioritize all jobs in the respective state, ``--pending``
+includes both. To skip a confirmation, pass ``--force``.

Michael

Reply via email to