On Mon, Nov 19, 2012 at 08:26:13PM +0000, Dato Simó wrote:
> LGTM.
>
> > --- /dev/null
> > +++ b/htools/Ganeti/Types.hs
> > @@ -0,0 +1,85 @@
> > +{-# LANGUAGE TemplateHaskell #-}
> > +
> > +{-| Some common Ganeti types.
> > +
> > +This holds types common to both core work, and to htools. Types that
> > +are very core specific (e.g. configuration objects) should go in
> > +'Ganeti.Objects', while types that are specific to htools in-memory
> > +representation should go into 'Ganeti.HTools.Types'.
> > +
> > +-}
>
> Very useful module description, LGTM++.
Thanks, glad to hear you like it!
In the end, it looks like hlint barfs on this, because removing the only
splice from TestHTools (“$(genArbitrary …)”) makes the TemplaHaskell
pragma unneeded, so I'll commit with:
diff --git a/htest/Test/Ganeti/TestHTools.hs b/htest/Test/Ganeti/TestHTools.hs
index e892de0..44b53c8 100644
--- a/htest/Test/Ganeti/TestHTools.hs
+++ b/htest/Test/Ganeti/TestHTools.hs
@@ -1,4 +1,3 @@
-{-# LANGUAGE TemplateHaskell #-}
{-# OPTIONS_GHC -fno-warn-orphans #-}
{-| Common functionality for htools-related unittests.
--
thanks,
iustin
