Hi Guido, can you please tell me what environment / hlint version you used for this? I cannot reproduce it.
Thanks, Helga On Fri, Dec 7, 2012 at 12:37 PM, Guido Trotter <ultrot...@google.com> wrote: > On wheezy also: > htest/Test/Ganeti/Network.hs:49:3: Parse error > Error message: > Parse error: Last statement in a do-block must be an expression > Code: > network_type <- genMaybe genNetworkType > mac_prefix <- genMaybe genName > > family <- arbitrary > net <- genName >>= mkNonEmpty > net6 <- genMaybe genName > > > Writing report to doc/hs-lint.html ... > 1 suggestion (68 ignored) > make: *** [hlint] Error 1 > > Thanks, > > Guido > > > On Fri, Dec 7, 2012 at 11:27 AM, Michele Tartara <mtart...@google.com> > wrote: > > On Fri, Dec 7, 2012 at 10:44 AM, Guido Trotter <ultrot...@google.com> > wrote: > >> > >> Notes: from tests this morning: this depends on "bitvec", rather than > >> bit-vector. > >> bitvec in turn depends on vector 0.9.1 *or below* as anything above > >> has removed support for some functionality that bicvec uses. > >> Currently 0.9.1 is what most stable distributions carry, but we should > >> perhaps investigate with the bitvec author whether he intends to port > >> the library further, or choose a different one. > >> > >> Considering we need to have this discussion, for now LGTM on the revert. > > > > > > Another update on this issue. > > After further investigation, it turns out that the library the patch > depends > > on is actually "bit-vector", as stated by Helga, and not "bitvec". > > > > Unfortunately, bit-vector depends on vector-0.9.1 as well. > > What makes the issue even worse, is that if you install vector > > cabal install --global vector > > it gets installed at version 0.10.0 > > > > Later, if you install bit-vector > > cabal install --global bit-vector > > is gets installed and installs as its dependency vector-0.9.1 as well, > that > > is the last version it is able to work correctly with. > > > > Unfortunately, in this situation, with two vector versions installed, not > > only the problem pointed out by Guido persists (only the older version of > > the dependency works) but there is a conflict as well. In fact, ghc is > not > > able to properly acknowledge the dependency (at least given how the code > of > > the patch is written, maybe it is possible to change it) and tries to use > > bit-vector with vector 0.10.0, and the compilation fails. > > So, even if we decide to keep using bit-vector, we should really pay > > attention to never require vector > 0.9.1 for anything. > > > > > > As a side note, the patch also fails the hlint check: > > htest/Test/Ganeti/Network.hs:147:46: Error: Redundant if > > Found: > > if b then a else True > > Why not: > > (not b || a) > > > > > > Best, > > Michele > > > > -- > Guido Trotter > SRE - Corp Computing Services (aka Horsepower) > Google Germany >
