LGTM Thanks,
Guido On Fri, Jan 18, 2013 at 3:44 PM, Christos Stavrakakis <[email protected]> wrote: > If opportunistic_locking is used, then 'node_whitelist' parameter passed > to the allocator is set to the LU's owned node locks. However, LU owned_locks > has type of 'set' while IReqInstanceAlloc expects type of > 'ht.TMaybeListOf(ht.TNonEmptyString)'. > --- > lib/cmdlib.py | 4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/lib/cmdlib.py b/lib/cmdlib.py > index cf4d902..afc801f 100644 > --- a/lib/cmdlib.py > +++ b/lib/cmdlib.py > @@ -10297,7 +10297,7 @@ class LUInstanceCreate(LogicalUnit): > """ > if self.op.opportunistic_locking: > # Only consider nodes for which a lock is held > - node_whitelist = self.owned_locks(locking.LEVEL_NODE) > + node_whitelist = list(self.owned_locks(locking.LEVEL_NODE)) > else: > node_whitelist = None > > @@ -11241,7 +11241,7 @@ class LUInstanceMultiAlloc(NoHooksLU): > > if self.op.opportunistic_locking: > # Only consider nodes for which a lock is held > - node_whitelist = self.owned_locks(locking.LEVEL_NODE) > + node_whitelist = list(self.owned_locks(locking.LEVEL_NODE)) > else: > node_whitelist = None > > -- > 1.7.2.5 > -- Guido Trotter Ganeti engineering Google Germany
