The additional comma makes this file invalid JSON. Also,
I removed the "#default-nicparams", since it seems to be intended
as an actual parameter to be used and not just a comment (since there is
a sufficient comment above this line). So far the parameter was used in
qa_cluster.py, line 119 and following:
  nicparams = qa_config.get("default-nicparams", None)
This tries to retrieve 'default-nicparams', but fails, because the config
says '#default-nicparams'. However, this bug was masked by the fact that
the cluster QA falls back to some default. Since I intended to use it in
the network QA, I fixed this here as well.

Signed-off-by: Helga Velroyen <[email protected]>
---
 qa/qa-sample.json |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/qa/qa-sample.json b/qa/qa-sample.json
index 9b96484..61ce0b9 100644
--- a/qa/qa-sample.json
+++ b/qa/qa-sample.json
@@ -24,9 +24,9 @@
   "#master-netdev": "xen-br0",
 
   "# Default network interface parameters": null,
-  "#default-nicparams": {
+  "default-nicparams": {
     "mode": "bridged",
-    "link": "xen-br0",
+    "link": "xen-br0"
   },
 
   "os": "debian-etch",
-- 
1.7.7.3

Reply via email to