On Thu, Jan 24, 2013 at 19:12 +0100, Iustin Pop <[email protected]> wrote: > On Thu, Jan 24, 2013 at 02:06:44AM +0000, Dato Simó wrote: > > In particular:
> > - make ArHealthy take an optional AutoRepairData; this allows to > > represent the situation where a repair completed successfully, and > > hence there's an associated tag we might want to know about. > > - add an 'arTag' member to AutoRepairData to store the exact tag this > > data was derived from; this allows for easier removal of the tag when > > its associated state is superseded. > Is this the tag as read from the cluster? If so, maybe arOriginalTag > would be more appropriate. Not sure, just thinking. Your suggestion follows from the description, and I would fully agree with it, except that the description is not complete. At first arTag was indeed just the original tag, but later on I also use the field to store the tag that will be written to the instance object. So I prefer to keep the 'arTag' name, and add to the description: "It also stores the tag that will be written to the cluster when a new AutoRepairData record is created." Sounds acceptable? Thanks, -- Dato Simó | [email protected] Corp Fleet Management / Ganeti SRE (Dublin)
