2013/1/30 Bernardo Dal Seno <[email protected]>: > + # Test removing instance with offline drbd secondary > + if qa_config.TestEnabled("instance-remove-drbd-offline"): > + # Make sure the master is not put offline > + snode = qa_config.AcquireNode(exclude=qa_config.GetMasterNode()) > + try: > + pnode = qa_config.AcquireNode(exclude=snode) > + try: > + instance = qa_instance.TestInstanceAddWithDrbdDisk([pnode, snode]) > + qa_node.MakeNodeOffline(snode, "yes") > + try: > + RunTest(qa_instance.TestInstanceRemove, instance) > + finally: > + qa_node.MakeNodeOffline(snode, "no") > + finally: > + qa_config.ReleaseNode(pnode) > + finally: > + qa_config.ReleaseNode(snode) > + # FIXME: This test leaves a DRBD device and two LVs behind > + # Cluster-verify would fail
This is indeed not good. Tests should, with some exceptions like creating instances, be idempotent and leave the cluster in the same state as it was before (otherwise ordering and/or configuration of tests can cause/hide problems). Is there a chance for you to fix this in a separate patch? Michael -- You received this message because you are subscribed to the Google Groups "ganeti-devel" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/groups/opt_out.
