Updates:
Status: Fixed
Comment #2 on issue 352 by [email protected]: Adding tags to a network
raises exceptions
http://code.google.com/p/ganeti/issues/detail?id=352
fixed with:
commit 0ae4b3551221e980262dadae9735dd652ba9eb58
Author: Helga Velroyen <[email protected]>
Date: Wed Jan 30 16:56:20 2013 +0000
Removes check for conflicts from NetworkDisconnect
This removes the check for conflicts from the Haskell
version of the OpCode NetworkDisconnect. This alignes
the Haskell code with the patch
"Force conflicts check in LUNetworkDisconnect" (which
is currently under review). I will submit these patches
together then.
Signed-off-by: Helga Velroyen <[email protected]>
Reviewed-by: Michael Hanselmann <[email protected]>
commit 1cce2c47da54574b7face60da45665af3e19795f
Author: Helga Velroyen <[email protected]>
Date: Wed Jan 30 17:35:10 2013 +0100
If _UnlockedLookupNetwork() fails raise error
Make _UnlockedLookupNetwork() raise OpPrereqError (instead of returning
None) in case it does not find the requested network. Remove useless and
duplicate code such as:
if net_uuid is None:
raise...
Signed-off-by: Dimitris Aragiorgis <[email protected]>
Reviewed-by: Helga Velroyen <[email protected]>
commit 6bb939a2171bcfa554736260543c0bd7b5ae0e51
Author: Helga Velroyen <[email protected]>
Date: Wed Jan 30 17:12:26 2013 +0100
Force conflicts check in LUNetworkDisconnect
Until now if one disconnects a network with --no-conflicts-check
and then remove it, there is a possibility to leave instances with NICs
referencing non-existing networks. This causes network queries,
instance removal and modification to fail.
This patch allows a network to be disconnected from a nodegroup,
only if instances residing in the nodegroup do not have NICs attached
to the network. Otherwise OpPrereqError is raised. The
--no-conflicts-check option is removed from the gnt-network disconnect
command as well.
Signed-off-by: Dimitris Aragiorgis <[email protected]>
Reviewed-by: Helga Velroyen <[email protected]>
