LGTM, Thanks,
Guido On 14 May 2013 13:53, "Michele Tartara" <[email protected]> wrote: > On Tue, May 14, 2013 at 1:28 PM, Guido Trotter <[email protected]>wrote: > >> On Tue, May 14, 2013 at 11:49 AM, Michele Tartara <[email protected]>wrote: >> >>> On Tue, May 14, 2013 at 11:30 AM, Guido Trotter <[email protected]>wrote: >>> >>>> The watcher is installed sometimes even if the node is not joined to a >>>> cluster. It performs different actions on the matter, nodes, and machines >>>> without a cluster. >>>> >>>> This snippet of code is in the same function that takes care of >>> starting all the daemons that should be running on all nodes (currently, >>> noded and confd) >>> This function is called by _GlobalWatcher, before checking whether it's >>> running on the master node. >>> >>> I hope this answers your question. >>> >>> >> This should be fine (as noded shouldn't be started before a cluster is in >> place). But please also double check. (should be easy to do, just >> deploying this watcher on a node where there is no cluster, and calling it, >> to verify it doesn't start the daemon). :) >> > > I confirm that running the watcher in a node that is not part of a cluster > does not start the monitoring daemon, nor noded. > > Cheers, > Michele >
