On 15 May 2013 08:43, Thomas Thrainer <[email protected]> wrote: > > On Tue, May 14, 2013 at 7:52 PM, Bernardo Dal Seno <[email protected]> > wrote: >> >> On 14 May 2013 15:52, Thomas Thrainer <[email protected]> wrote: >> > LUTags* and their base class, TagsLU, are extracted to tags.py. An >> > additional shared function, _ShareAll, is extracted to common.py for >> > shared usage. >> >> Shouldn't the move of _ShareAll be part of the previous patch? > > > I extracted helper functions only in the moment when they were used by at > least two files. _ShareAll was previously only used in instance.py, but this > patch extracted tags.py which also requires it. That's why it's in this > patch. > > BTW, this pattern repeats itself over the course of the whole patch series. > There are a lot more functions extracted only in the moment another > extraction required it.
I noticed the pattern after reviewing the following patches, and I forgot to come back and LGTM this. The first patch confused me, as I thought it was supposed to take out all the common parts. Anyway, LGTM, thanks! Bernardo
