On 16 May 2013 10:23, Thomas Thrainer <[email protected]> wrote: > All LUNode* classes are extracted to node.py. Common functions are moved > to common.py if used by non-node logical units as well. > > Signed-off-by: Thomas Thrainer <[email protected]> > --- > Makefile.am | 1 + > lib/cmdlib/__init__.py | 1672 > +------------------------------------ > lib/cmdlib/common.py | 139 +++ > lib/cmdlib/node.py | 1569 ++++++++++++++++++++++++++++++++++ > test/py/ganeti.cmdlib_unittest.py | 2 +- > 5 files changed, 1720 insertions(+), 1663 deletions(-) > create mode 100644 lib/cmdlib/node.py
LGTM except for the fact that the private functions in node.py should precede the classes. Thanks, Bernardo
