Reworded to:

    Reformat and define exports in cmdlib/__init__.py

    cmdlib/__init__.py now simply defines the interface of the cmdlib module
    by importing all classes which should be visible to clients.

    Also don't ignore C0302 (Too many lines in module) any more.

    Signed-off-by: Thomas Thrainer <[email protected]>


On Thu, May 16, 2013 at 7:31 PM, Bernardo Dal Seno <[email protected]>wrote:

> On 16 May 2013 10:23, Thomas Thrainer <[email protected]> wrote:
> > cmdlib/__init__.py now simply defines the interface of the cmdlib module
> > by importing all classes which should be visible to clients.
>
> LGTM, but the title of this patch is misleading (almost irrelevant
> :-). I'd like to celebrate the removal of the silencing of the pylint
> warning, so leave it in the comment, but the title should be a summary
> of the sentence above.
>
> >
> > Signed-off-by: Thomas Thrainer <[email protected]>
> > ---
> >  lib/cmdlib/__init__.py | 147
> +++++++++++++++++++++++++++++++------------------
> >  1 file changed, 94 insertions(+), 53 deletions(-)
>
> Thanks,
> Bernardo
>



-- 
Thomas Thrainer | Software Engineer | [email protected] |

Google Germany GmbH
Dienerstr. 12
80331 München

Registergericht und -nummer: Hamburg, HRB 86891
Sitz der Gesellschaft: Hamburg
Geschäftsführer: Graham Law, Katherine Stephens

Reply via email to