On 17 May 2013 10:55, Thomas Thrainer <[email protected]> wrote: > Fist: Thanks a million for reviewing this patch series so thoroughly! I > guess it as least as much fun as splitting cmdlib it :)
Thank you for your work! And at least I had fun in writing the script to preprocess all the patches. > Reworded commit message: > > cmdlib: Cleanup public/private functions > > All functions/classes which are used outside of their defining module > (with tests as an exception) no longer have a leading underscore. > > Signed-off-by: Thomas Thrainer <[email protected]> > > > I went through all the renamed functions and realigned calls to them where > appropriate. But as there is no automatic check, I can't be 100% sure :( > Rather long and boring Interdiff: I really hoped you wouldn't to that... :-) The changes that you've made are ok, if there are some missing, someone else will fix them when they'll notice them. LGTM, thanks. Bernardo
