On Tue, May 21, 2013 at 09:43:33AM +0200, Guido Trotter wrote: > On Thu, May 16, 2013 at 8:43 PM, Klaus Aehlig <[email protected]> wrote: > > > So far, hroller ignores the fact, that non-redundant instances exist. > > One option to deal is non-redundant instances is to not schedule those > > nodes for reboot. This is supported by adding the option > > --ignore-non-redundant. > > > > Signed-off-by: Klaus Aehlig <[email protected]> > > > > LGTM
There's a typo in the commit-message. It should end in "the option --skip-non-redundant". If you look at the patch, the option is really named that way. > (are there tests for this?) There is a rather subtle test for this added as a side product of the test in patch 5. If you look at the first test in | ./test/hs/hroller --skip-non-redundant -t $TESTDATA_DIR/hroller-nonredundant.data | >>>2 | Error: Cannot create node graph | >>>=1 | | ./test/hs/hroller --no-headers --ignore-non-redundant -t $TESTDATA_DIR/hroller-nonredundant.data | >>>/^node-01-00.,node-01-00.,node-01-00.,node-01-00.,node-01-00.,node-01-000$/ | >>>= 0 we at least verify that we optain the empty graph after skipping all the nodes with non-redundant instances. I'll write an additional patch with a more explicit test. Best, Klaus -- Klaus Aehlig Google Germany GmbH, Dienerstr. 12, 80331 Muenchen Registergericht und -nummer: Hamburg, HRB 86891 Sitz der Gesellschaft: Hamburg Geschaeftsfuehrer: Graham Law, Katherine Stephens
