Yeah, but 5000 is _really_ long, isn't it? BTW, here are all files longer than 2000 lines (which are not a lot, IMHO):
2028 ./test/py/ganeti.cmdlib_unittest.py 2180 ./lib/rapi/client.py 2191 ./lib/hypervisor/hv_kvm.py 2204 ./lib/opcodes.py 2207 ./lib/objects.py 2470 ./lib/constants.py 2507 ./lib/cmdlib/instance_storage.py 2642 ./lib/config.py 2689 ./test/py/ganeti.locking_unittest.py 2722 ./lib/jqueue.py 2753 ./test/py/ganeti.jqueue_unittest.py 2786 ./lib/query.py 2874 ./lib/cmdlib/cluster.py 3446 ./lib/bdev.py 3459 ./lib/cmdlib/instance.py 4129 ./lib/cli.py 4131 ./lib/backend.py (this actually tempted me to lower the limit to 3000 and just ignore C0302 in the longest four files, but then we wouldn't have an upper boundary for those four any more...) Thanks, Thomas On Wed, May 22, 2013 at 3:54 PM, Guido Trotter <[email protected]> wrote: > > > > On Wed, May 22, 2013 at 3:51 PM, Thomas Thrainer <[email protected]>wrote: > >> The longest Python files we still have are around 4200 lines long. In >> order to prevent future growth, limit the maximum file length (checked >> by pylint) to 4500 lines. >> >> Signed-off-by: Thomas Thrainer <[email protected]> >> > > Didn't we say "multiple of 1000". > Anyway, LGTM > > Thanks, > Guido > > -- Thomas Thrainer | Software Engineer | [email protected] | Google Germany GmbH Dienerstr. 12 80331 München Registergericht und -nummer: Hamburg, HRB 86891 Sitz der Gesellschaft: Hamburg Geschäftsführer: Graham Law, Katherine Stephens
