On 22 May 2013 18:32, Michele Tartara <mtart...@google.com> wrote:
> On Wed, May 22, 2013 at 6:22 PM, Michele Tartara <mtart...@google.com>
> wrote:
>>
>> On Wed, May 22, 2013 at 5:54 PM, Guido Trotter <ultrot...@google.com>
>> wrote:
>>>
>>>
>>>
>>>
>>> On Wed, May 22, 2013 at 5:45 PM, Michele Tartara <mtart...@google.com>
>>> wrote:
>>>>
>>>> On Wed, May 22, 2013 at 5:00 PM, Guido Trotter <ultrot...@google.com>
>>>> wrote:
>>>>>
>>>>>
>>>>>
>>>>>
>>>>> On Wed, May 22, 2013 at 4:16 PM, Michele Tartara <mtart...@google.com>
>>>>> wrote:
>>>>>>
>>>>>> Add to the NEWS file the list of modifications performed during the
>>>>>> 2.8
>>>>>> development cycle.
>>>>>>
>>>>>> Signed-off-by: Michele Tartara <mtart...@google.com>
>>>>>> ---
>>>>>>  NEWS | 38 +++++++++++++++++++++++++++++++++++++-
>>>>>>  1 file changed, 37 insertions(+), 1 deletion(-)
>>>>>>
>>>>>> diff --git a/NEWS b/NEWS
>>>>>> index 91d22f1..2a35a8d 100644
>>>>>> --- a/NEWS
>>>>>> +++ b/NEWS
>>>>>> @@ -7,7 +7,6 @@ Version 2.8.0 beta1
>>>>>>
>>>>>>  *(unreleased)*
>>>>>>
>>>>>> -- The minimum Python version needed to run Ganeti is now 2.6.
>>>>>>  - The :doc:`Remote API <rapi>` daemon now supports a command line
>>>>>> flag
>>>>>>    to always require authentication, ``--require-authentication``. It
>>>>>> can
>>>>>>    be specified in ``$sysconfdir/default/ganeti``.
>>>>>> @@ -22,6 +21,43 @@ Version 2.8.0 beta1
>>>>>>    creation.
>>>>>>  - ``cfgupgrade`` now supports a ``--downgrade`` option to bring the
>>>>>>    configuration back to the previous stable version.
>>>>>> +- Instance policy can contain multiple instance specs, as described
>>>>>> in
>>>>>> +  the “Constrained instance sizes” section of :doc:`Partitioned
>>>>>> Ganeti
>>>>>> +  <design-partitioned>`. As a consequence, it's not possible to
>>>>>> partially change
>>>>>> +  or override instance specs. Bounding specs (min and max) can be
>>>>>> specified as a
>>>>>> +  whole using the new option ``--ipolicy-bounds-specs``, while
>>>>>> standard
>>>>>> +  specs use the new option ``--ipolicy-std-specs``.
>>>>>
>>>>>
>>>>> Can you bump this up and put it into an incompatibility/change section?
>>>>
>>>>
>>>> Ok.
>>>>
>>>>>
>>>>>
>>>>>>
>>>>>> +- Disk templates in group ipolicy can be restored to the default
>>>>>> value.
>>>>>> +- The output of the info command of gnt-cluster, gnt-group, gnt-node,
>>>>>> +  gnt-instance is a valid YAML object.
>>>>>
>>>>>
>>>>> Can you bump this up and put it into an incompatibility/change section?
>>>>
>>>>
>>>> Ok.
>>>>
>>>>>
>>>>>
>>>>>>
>>>>>> +- Initial support for diskless instances and virtual clusters in QA.
>>>>>> +- More QA and unit tests for instance policies.
>>>>>>
>>>>>> +- Every opcode now contains a reason trail (visible through ``gnt-job
>>>>>> info``)
>>>>>> +  describing why the opcode itself was executed.
>>>>>> +- The monitoring daemon is now available. It allows users to query
>>>>>> the cluster
>>>>>> +  for obtaining information about the status of the system. The
>>>>>> daemon is only
>>>>>> +  responsible for providing the information over the network: the
>>>>>> actual data
>>>>>> +  gathering is performed by data collectors (currently, only the DRBD
>>>>>> status
>>>>>> +  collector is available).
>>>>>> +- In order to help developers work on Ganeti, a new script
>>>>>> +  (``devel/build_chroot``) is provided, for building a chroot that
>>>>>> contains all
>>>>>> +  the required development libraries and tools for compiling ganeti
>>>>>> for a Debian
>>>>>> +  Squeeze system.
>>>>>
>>>>>
>>>>> s/for/on/ ?
>>>>
>>>>
>>>> It is meant as in "compiling Ganeti so that it can be later run on a
>>>> Debian Squeeze system". It's definitely also "on" a Debian system, but I
>>>> don't know which one is better.
>>>>
>>>
>>>
>>> Sure, either way is ok. Using for also has a for repetition in the
>>> sentence, though. :)
>>
>>
>> Let's go for "on", then.
>>
>>>
>>>>>
>>>>>
>>>>>>
>>>>>> +- A new tool, ``harep``, for performing self-repair and recreation of
>>>>>> instances
>>>>>> +  in Ganeti was added.
>>>>>> +- Split queries are enabled for network and export.
>>>>>> +
>>>>>
>>>>>
>>>>> Only? I believe also node and basically everything else except
>>>>> instance, or am I wrong?
>>>>
>>>>
>>>> Yes, but if I'm not mistaken they where enabled before 2.8, in patch
>>>> d45a824b3404d2be348208ae6ef9b3de5e5e7924.
>>>>
>>>
>>> gnt-node and anything using rpc was subsequently disabled in 2.7, and is
>>> only in use from 2.8 on.
>>
>>
>> Ok, I missed this part. I'll fix it.
>>
>> Thanks,
>> Michele
>
>
>
> Here is the interdiff:
> diff --git a/NEWS b/NEWS
> index 2a35a8d..fe63e5e 100644
> --- a/NEWS
> +++ b/NEWS
> @@ -7,6 +7,21 @@ Version 2.8.0 beta1
>
>  *(unreleased)*
>
> +Incompatible/important changes
> +~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> +
> +- Instance policy can contain multiple instance specs, as described in
> +  the “Constrained instance sizes” section of :doc:`Partitioned Ganeti
> +  <design-partitioned>`. As a consequence, it's not possible to partially
> change
> +  or override instance specs. Bounding specs (min and max) can be specified
> as a
> +  whole using the new option ``--ipolicy-bounds-specs``, while standard
> +  specs use the new option ``--ipolicy-std-specs``.

Apparently this patch hasn't been submitted yet, so I'd like to
correct an omission (sorry, my mystake). Can you please add this:

- New command ``show-ispecs-cmd`` for ``gnt-cluster`` and ``gnt-group``.
  It prints the command line to set the current policies, to ease
  changing them.

Also,

> +- A new tool, ``harep``, for performing self-repair and recreation of 
> instances
> +  in Ganeti was added.

s/was/has been/ for consistency with the rest.

> +For Python:
> +- The minimum Python version needed to run Ganeti is now 2.6.
> +- ``yaml`` library.

python-yaml  is needed only for development (it's used in QA).

And the rest LGTM.

Thanks,
Bernardo

Reply via email to