Hi, It would be great if you could send the rebased final patch series again via the normal procedure. Then reviewing is a lot easier...
Thanks, Thomas On Thu, Jun 20, 2013 at 3:06 PM, Dimitris Aragiorgis <[email protected]>wrote: > Hi Thomas, > > based on Guido's sayings I think the patch will go to master and without > the > Makefile "sugar" you and I suggested (distcheck and install-exec-hook). > Do you want me to rebase the patches and remove the "sugar" or will > you do it? I think besides documenting the link to vif-ganeti there > are no pending issues right? > > Thanks a lot, > dimara > > > * Guido Trotter <[email protected]> [2013-06-18 12:47:46 +0200]: > > > On Mon, Jun 17, 2013 at 6:00 PM, Dimitris Aragiorgis <[email protected]> > wrote: > > > Hi, > > > > > > * Guido Trotter <[email protected]> [2013-06-17 13:56:46 +0200]: > > > > > >> > > >> Why is it a bug fix? Which bug does it fix? > > >> > > >> >> > > > > > > Well it is more like an inconsistent behavior than a bug. Currently I > define > > > a NIC with mode=routed,link=lala and I get a bridged one on system's > default bridge. > > > I don't think that this is the expected functionality, right? > > > > > > > Indeed not, but it is a known drawback, rather than a bug we just found. > > So this should still be for master, as it's a new feature. :) > > > > > So, shall we drop the install-exec-hook and Thomas' distcheck > workaround > > > and just document that the user must link the script after the > > > installation? I guess cluster verify can follow, but we already already > > > hv_base.OPT_FILE_CHECK for vif-script parameter which can be used > instead. > > > > Ok, let's just leave it at documentation level, for now. > > > > Thanks, > > Guido > > -----BEGIN PGP SIGNATURE----- > Version: GnuPG v1.4.10 (GNU/Linux) > > iQEcBAEBCAAGBQJRwv5WAAoJEMk10sCdtK5jcW0H/Aoe5qhN8TCFKxqEvhWlCU+2 > zbE2rr2IcR/5pTTGADQC6a81PylwmBpInA0jWvRW2QRoXZfSTAmECJetqRzcE6Dz > 80e73fVwWA8iG/XROOLku7oEyBmX4DLv93sDi3DbtqoBfbbHuofFnEEAhpd2jkrC > e3VGyWQKIuOggtv6aymHBNMXTjnAW8LBAsdDGg86JpZMwGBW23jG4jHyQCQa4Bvh > wGXLSEFlk5nrUTXqKtn/8tEdRVX6ydMTgymTS9PQydK5pq08RGXczGoHlMURrvOo > 26MtcR9SpaNd/LLQ3R0mdYESSg43zFOvDPSrW/U6YPGgs6NiSSrJKC+hnaWSZCU= > =rhcB > -----END PGP SIGNATURE----- > > -- Thomas Thrainer | Software Engineer | [email protected] | Google Germany GmbH Dienerstr. 12 80331 München Registergericht und -nummer: Hamburg, HRB 86891 Sitz der Gesellschaft: Hamburg Geschäftsführer: Graham Law, Katherine Stephens
