+list
---------- Forwarded message ---------- From: Guido Trotter <[email protected]> Date: Thu, Jul 11, 2013 at 3:12 PM Subject: Re: [PATCH stable-2.8 0/2] Add luxiReqQueryNetworks to LuxiOp To: Klaus Aehlig <[email protected]> On Thu, Jul 11, 2013 at 3:04 PM, Klaus Aehlig <[email protected]> wrote: > >> Thanks. Would it make sense to add tests so that it's impossible to >> add "secret" luxi methods in the future? > > It certainly would make sense, but currently I have no idea how > such a test could find out which luxi methods _actually_ are > supported. > For example we could add a check in ClientOps handle_request that says that if the method is not part of luxi.REQ_ALL it should return an error. This way we're sure no "secret" luxi method can be added and actually work. It's not a unittest but it should do the job. More complex would be to check for all luxi.REQ_* and such, but perhaps the first solution could be fine. Thanks, Guido -- Guido Trotter Ganeti Engineering Google Germany GmbH Dienerstr. 12, 80331, München Registergericht und -nummer: Hamburg, HRB 86891 Sitz der Gesellschaft: Hamburg Geschäftsführer: Graham Law, Katherine Stephens Steuernummer: 48/725/00206 Umsatzsteueridentifikationsnummer: DE813741370
