Re: [PATCH master 2/7] Extending nicparams to support vlan parameter

[Sebastian Gebhard]

Correct, thanks for the hint. I changed it to None.

Am 15.07.13 10:07, schrieb Klaus Aehlig:
> On Sun, Jul 14, 2013 at 05:05:08PM +0200, Sebastian Gebhard wrote:
>> This parameter is used to store the vlans each nic is connected to.
>> It is only used if the network is in openvswitch mode.
>>
>> Signed-off-by: Sebastian Gebhard <s...@fs.ei.tum.de>
>> ---
>>  lib/constants.py      | 5 +++++
>>  src/Ganeti/Objects.hs | 1 +
>>  2 files changed, 6 insertions(+)
>> @@ -2255,6 +2259,7 @@ del _LV_DEFAULTS, _DRBD_DEFAULTS
>>  NICC_DEFAULTS = {
>>    NIC_MODE: NIC_MODE_BRIDGED,
>>    NIC_LINK: DEFAULT_BRIDGE,
>> +  NIC_VLAN: "",
>>    }
> "" or None?
>
> Since it's Maybe String, I would have expected Nothing as default.
>