Hi, On Jul 26, 2013, at 3:09 PM, Guido Trotter <[email protected]> wrote:
> On Fri, Jul 26, 2013 at 2:20 PM, <[email protected]> wrote: >> From: Izhar <[email protected]> >> >> This patch removes the hypervisor parameter mem_path from the >> instance level. >> >> Signed-off-by: Izhar <[email protected]> > > This needs also updates for query.py (apparently we don't allow > hv/<param> if the param is global, so we shouldn't also if it's > nodegroup global. Same for instance export. A "git grep HVC_GLOBALS" > should show which files you also need to change and/or add relevant > ORs too. > > Also please explain in the commit why you're adding a new global > constant instead of using the existing one, as later you'll be moving > the hv parameters to the nodegroup level and then these parameters > will be settable at that level but now below. > I have redone the patch and included the changes in the MAN page as well. The commit message has also been updated. NEWS will be updated in the final patch when the hypervisor options are added at nodegroup level and inheritance of the parameters is satisfied. /Izhar
