On Thu, Jul 25, 2013 at 1:41 AM, Dimitris Aragiorgis <[email protected]> wrote: > Add pci slot in NIC/Disk objects. This slot will be used only > by hypervisor code. Currently only KVM will use it and store it > temporarily in runtime files. > Add HOTPLUG_* constants to define device types an hotplug actions. > > Signed-off-by: Dimitris Aragiorgis <[email protected]> > --- > lib/constants.py | 6 ++++++ > lib/objects.py | 7 ++++--- > 2 files changed, 10 insertions(+), 3 deletions(-) > > diff --git a/lib/constants.py b/lib/constants.py > index 35b47ae..35eb6bc 100644 > --- a/lib/constants.py > +++ b/lib/constants.py > @@ -697,6 +697,12 @@ DDMS_VALUES_WITH_MODIFY = (DDMS_VALUES | frozenset([ > ])) > # TODO: DDM_SWAP, DDM_MOVE? > > +# hotplug > +HOTPLUG_DISK = "hotdisk" > +HOTPLUG_NIC = "hotnic"
How about HOTPLUG_TARGET_DISK (and NIC) Would it make sense to also have HOTPLUT_ALL_TARGETS > +HOTPLUG_ADD = "hotadd" > +HOTPLUG_REMOVE = "hotremove" > + And HOTPLUG_ACTION_ADD (and REMOVE) And HOTPLUT_ALL_ACTIONS, here? This way we don't confuse the two, since they're different things, related to hotplug. Thanks, Guido
