Hello Guido, Many thanks for the loooong and the detailed review! To sum up:
- 80% of the comments are style issues in order the patch to comply to the ganeti code standards - docstrings: I got it! There should always be one that reflects to the actual implementation - In case hotplug is not possible (old devices, no fdsend, chroot, etc..) log warnings or raise exceptions - parse 'help info' monitor command to check if hotplug commands are supported - make HotplugDevice a base method and let other hypervisors raise a NotImplemented exception. - add REPLUG action for nic modifications - move hypervisor agnostic code away from hv_kvm.py to backend.py - make GenernateKVMBlockDeviceOptions return only those options and not change/return the kvm_cmd Do I miss anything important? I'll try to apply all that in the next few days and when I have all issues covered I'll resend the whole patch rebased on current master. Thanks again for the feedback, dimara * Dimitris Aragiorgis <[email protected]> [2013-07-25 02:41:07 +0300]: > Hello team, > > This patch set implements device hotplugging for KVM hypervisor. > It includes all design modifications/suggestions discussed in the > past few weeks in the mailing list. > > Looking forward to your feedback, > dimara
signature.asc
Description: Digital signature
